Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Model] Implement CoGSL #170

Merged
merged 9 commits into from
Nov 14, 2023
Merged

[Model] Implement CoGSL #170

merged 9 commits into from
Nov 14, 2023
+864 −2

Conversation

xy-Ji
Copy link
Contributor

@xy-Ji xy-Ji commented Oct 15, 2023

No description provided.

dddg617
dddg617 reviewed Oct 19, 2023
View reviewed changes
examples/cogsl/cogsl_trainer.py Outdated
os.environ['TL_BACKEND'] = 'torch'

import sys
sys.path.insert(0, os.path.abspath('../../')) # adds path2gammagl to execute in command line.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the line 5 and line 6 as these are of no use.

gammagl/models/cogsl.py


# base
class GCN_two(nn.Module):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there are GCN_one and GCN_two? Why not merge them together?

gammagl/models/cogsl.py
return out


class GCN_two_ggl(nn.Module):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, what is the difference between the GCN_two and GCN_two_ggl?

@dddg617 dddg617 changed the title cogsl [Model] Implement Cogsl Oct 19, 2023
@dddg617 dddg617 changed the title [Model] Implement Cogsl [Model] Implement CoGSL Oct 19, 2023
@dddg617
Copy link
Contributor

dddg617 commented Oct 31, 2023

I think you may do the following things:

  1. Add from .cogsl import CoGSLDataset in the gammagl.datasets.__init__.py. Otherwise, you will not be able to run the example.
  2. Add from .cogsl import CoGSLModel in the gammagl.models.__init__.py.
  3. Refer to the docs/source/api to add the docstring of the model. I think you need to modify the `docs/source/api/gammagl.datasets.rst.
  4. Modify the README.md to add your model name with the running status of the four backends.
  5. Modify the CONTRIBUTING.md to add your name and your laboratory (or university) name.

@xy-Ji xy-Ji closed this Nov 6, 2023
xy-Ji added 2 commits November 6, 2023 14:23
@xy-Ji
Merge remote-tracking branch 'origin/cogsl' into cogsl
ca205b8 
# Conflicts:
#	CONTRIBUTING.md
#	gammagl/models/__init__.py
@xy-Ji
Implement CoGSL model
4f421d3
@xy-Ji xy-Ji reopened this Nov 6, 2023
@dddg617 dddg617 merged commit 26e9bb5 into BUPT-GAMMA:main Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dddg617 dddg617

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xy-Ji @dddg617