Add IConicGradientBrush and a drawing implemention for Skia. #4745
+339
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I've refactored to name the brush ConicGradient to match the CSS name, and to default to angle 0 as being 12 on the clockface, again like CSS. |
olliholliday
changed the title
olliholliday
changed the title
|
I've looked at how to implement this for Direct2D but it's not a simple thing, the Mozilla Direct2D renderer has an implementation that uses a pixel shader which might be usable? I'm unsure of how to make this work. |
|
You could disable the test for the Direct2D1 backend. Still, it should not crash when the brush is being used in combination with the Direct2D1 backend. You can use a fallback for the Direct2D1 backend. |
|
I've added a D2D rendering implementation which is just a copy of the RadialGradientImpl - not sure how else to do this? |
Gillibald
reviewed
Oct 5, 2020
…on for Direct2D using SolidColorBrushImpl.
MarchingCube
approved these changes
Oct 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add render tests and expected results graphics.
What does the pull request do?
Currently supported gradient brushes are Linear and Radial. Skia and CSS both have support for so called Conic Gradient (CSS) and Sweep Gradient (Skia).
This type of gradient has equal colours for each angle around the center point - whereas a radial gradient has equal colours for each distance from the centerpoint - an example graphic can be seen here: https://css-tricks.com/snippets/css/css-conic-gradient/.
What is the updated/expected behavior with this PR?
This PR adds
ISweepGradientIConicGradient and a Skia drawing implementation.I have added rendering tests with expected results.
How was the solution implemented (if it's not obvious)?
The implementation closely matches existing gradient implementations. It passes through rendering straight to Skia via SKShader.
I added an additional property for Angle which allows you to set the angle that the gradient should start at, in Skia this is achieved via a rotation matrix.
I chose to specify the angle in degrees rather than radians, and I chose the default rotation value of 0 to conform to the Skia standard of the gradient stop at offset 0 runs horizontally from the center point to the right hand side. In CSS the default is for the first gradient stop to be vertical.I chose to specify the angle in degrees rather than radians, and I chose the default rotation value of 0 to conform to the CSS standard of the gradient stop at offset 0 runs vertically from the center point.
Checklist