Add instructions to deploy for testing purpose #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also adds features to use alternate resource names
ikedam
commented
Sep 17, 2018
| |GITHUB_API_TOKEN |github personal access token| | ||
| |GITHUB_USER |github username of the personal access token| | ||
| |GITMASK_SERVICE |Your own service name for gitmask, e.g. myown-gitmask-api.| | ||
| |GITMASK_SERVICE_NORMALIZE|Normalized value for GITMASK_SERVICE,removing special characters and captalize the first letter. e.g. Myowngitmaskapi | |
There was a problem hiding this comment.
GITMASK_SERVICE_NORMALIZE is used only in cloudformation-resources.yaml to allow public read for objects in the upload bucket.
I wonder we really need this permission as they are read only by process.js.
I think we can remove cloudformation-resources.yaml and make configurations simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I'm interested in your project, and want to contribute, especially to support #41.
I tried have gitmask run on my environment and update the document adding those instructions.
And I added changes to specify alternate resources (e.g. S3 bucket names, github account, and so on)
with environment variables.
This would make it easier for developers to contribute to gitmask.