-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kjob storage configuration #372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b6b1a1
to
242e0dd
Compare
242e0dd
to
b0778d6
Compare
57437a4
to
3adbc1e
Compare
b0c3311
to
e05fa27
Compare
pawloch00
reviewed
Mar 3, 2025
pawloch00
reviewed
Mar 3, 2025
f9dd51d
to
cbb1a5f
Compare
86125aa
to
4b929e9
Compare
cc: @pawloch00 @sharabiani PTAL |
pawloch00
approved these changes
Mar 4, 2025
sharabiani
reviewed
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the issues in a separate PR.
A missing part seems to be xpk run
gscfuse annotation.
Thank you for review! Created separate PR #408. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
XPK storage attach, storage create and storage delete commands should be updating Kubernetes volumes configuration for kjob so that kjob commands like kjobctl create interactive and kjobctl create slurm would be automatically mounting volumes managed by XPK storage subcommands. Only storages with --auto-mount=true should be added to kjob configuration.
Testing / Documentation
Testing details.