Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kjob storage configuration #372

Merged
merged 4 commits into from
Mar 5, 2025

Conversation

mbobrovskyi
Copy link
Collaborator

@mbobrovskyi mbobrovskyi commented Feb 14, 2025

Fixes / Features

  • Kjob storage configuration

XPK storage attach, storage create and storage delete commands should be updating Kubernetes volumes configuration for kjob so that kjob commands like kjobctl create interactive and kjobctl create slurm would be automatically mounting volumes managed by XPK storage subcommands. Only storages with --auto-mount=true should be added to kjob configuration.

Testing / Documentation

Testing details.

  • [ y/n ] Tests pass
  • [ y/n ] Appropriate changes to documentation are included in the PR

@mbobrovskyi mbobrovskyi force-pushed the mbobrovskyi/kjob-storage-configuration branch 2 times, most recently from 8b6b1a1 to 242e0dd Compare February 14, 2025 08:51
@mbobrovskyi mbobrovskyi changed the title Test Kjob storage configuration Feb 14, 2025
@mbobrovskyi mbobrovskyi force-pushed the mbobrovskyi/kjob-storage-configuration branch from 242e0dd to b0778d6 Compare February 14, 2025 09:31
@mbobrovskyi mbobrovskyi changed the base branch from development to develop February 14, 2025 09:32
@mbobrovskyi mbobrovskyi changed the base branch from develop to ppawl-cherry-pick February 14, 2025 09:32
Base automatically changed from ppawl-cherry-pick to develop February 14, 2025 11:49
@mbobrovskyi mbobrovskyi force-pushed the mbobrovskyi/kjob-storage-configuration branch 23 times, most recently from 57437a4 to 3adbc1e Compare February 21, 2025 09:05
@mbobrovskyi mbobrovskyi force-pushed the mbobrovskyi/kjob-storage-configuration branch 2 times, most recently from b0c3311 to e05fa27 Compare March 3, 2025 08:24
@mbobrovskyi mbobrovskyi force-pushed the mbobrovskyi/kjob-storage-configuration branch 10 times, most recently from f9dd51d to cbb1a5f Compare March 3, 2025 14:39
@mbobrovskyi mbobrovskyi force-pushed the mbobrovskyi/kjob-storage-configuration branch 2 times, most recently from 86125aa to 4b929e9 Compare March 3, 2025 15:48
@mbobrovskyi
Copy link
Collaborator Author

mbobrovskyi commented Mar 3, 2025

cc: @pawloch00 @sharabiani PTAL

@pawloch00 pawloch00 enabled auto-merge (squash) March 4, 2025 17:29
@pawloch00 pawloch00 disabled auto-merge March 4, 2025 17:30
@pawloch00 pawloch00 merged commit c7b4958 into develop Mar 5, 2025
17 checks passed
@pawloch00 pawloch00 deleted the mbobrovskyi/kjob-storage-configuration branch March 5, 2025 10:50
Copy link
Collaborator

@sharabiani sharabiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the issues in a separate PR.
A missing part seems to be xpk run gscfuse annotation.

@mbobrovskyi
Copy link
Collaborator Author

mbobrovskyi commented Mar 6, 2025

Please address the issues in a separate PR. A missing part seems to be xpk run gscfuse annotation.

Thank you for review! Created separate PR #408.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants