Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple address_filters() from EmulatorModuleTuple into HasAddressFilters #2869

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Decouple address_filters() from EmulatorModuleTuple into HasAddressFilters #2869

merged 2 commits into from
Jan 20, 2025

Conversation

tokatoka
Copy link
Member

No description provided.

@tokatoka
Copy link
Member Author

To avoid this <EdgeCoverageModule<StdAddressFilter, NopPageFilter, EdgeCoverageFullVariant, false, 0> as EmulatorModule<BytesInput, ClientState>>::update_address_filter

@tokatoka tokatoka requested a review from rmalmain January 20, 2025 16:01
rmalmain
rmalmain approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@rmalmain rmalmain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks

@tokatoka tokatoka merged commit 6ee26a8 into main Jan 20, 2025
107 checks passed
@tokatoka tokatoka deleted the addr_filter branch January 20, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmalmain rmalmain rmalmain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tokatoka @rmalmain