Fix #2853: split HasMutatorBytes trait into two traits.
#2856
Conversation
Railroad6230
changed the title
HasMutatorBytes] trait into two traits.HasMutatorBytes trait into two traits.
Railroad6230
force-pushed
the
pr2856
branch
4 times, most recently
from
314fee1 to
deeca27
Compare
|
i think HasMutatorVec is a better name than HasMutatorResizableBytes |
Railroad6230
force-pushed
the
pr2856
branch
2 times, most recently
from
c2b6b13 to
a9063d9
Compare
(See AFLplusplus#2853.) This commit attempts to improve the [`HasMutatorBytes`] trait to allow it to be used along with input types that cannot be resizable. [`HasMutatorBytes`] is split into two traits: - [`HasMutatorBytes`]: requires `bytes` and `bytes_mut`. - `HasMutatorResizableBytes`: requires [`HasMutatorBytes`], and also requires a few other methods for resizing / shrinking the underlying input type. N.B.: I believe that if merged, this would introduce a breaking change. [`HasMutatorBytes`]: https://github.com/AFLplusplus/LibAFL/blob/198cd5dbc5200bfba3df48cf2a14376e0f0e3000/libafl/src/inputs/bytes.rs#L26
Is the underlying container necessarily a Vec? |
|
not 100% i guess...? |
Ho right! I haven't thought of that.
Your call :) |
|
Thank you |
| @@ -11,7 +11,7 @@ use core::cell::RefCell; | |||
| use libafl_bolts::{ownedref::OwnedSlice, HasLen}; | |||
|
|
|||
| use super::ValueInput; | |||
| use crate::inputs::{HasMutatorBytes, HasTargetBytes}; | |||
| use crate::inputs::{HasMutatorBytes, HasMutatorResizableBytes, HasTargetBytes}; | |||
There was a problem hiding this comment.
I'd prefer to have HasFixedMutatorBytes since the default is that they are resizable(?)
Otherwise at least HasResizableMutatorBytes
There was a problem hiding this comment.
I absolutely understand for HasResizableMutatorBytes.
However, I'm not sure about resizable being the default. In my opinion, you start with "nothing", then a buffer, then a buffer that is mutable, then a buffer that is resizable (because resizable implies mutable in a way).
What do you think?
In any case, I'll open a second PR to fix that name.
edit: made a PR: #2862
…sizableBytes` to `HasMutatorBytes`. As discussed in AFLplusplus#2856 (comment). Sorry about that!
…sizableBytes` to `HasMutatorBytes`. As discussed in AFLplusplus#2856 (comment). Sorry about that!
…sizableBytes` to `HasMutatorBytes`. As discussed in AFLplusplus#2856 (comment). Sorry about that!
…FLplusplus#2856) (See AFLplusplus#2853.) This commit attempts to improve the [`HasMutatorBytes`] trait to allow it to be used along with input types that cannot be resizable. [`HasMutatorBytes`] is split into two traits: - [`HasMutatorBytes`]: requires `bytes` and `bytes_mut`. - `HasMutatorResizableBytes`: requires [`HasMutatorBytes`], and also requires a few other methods for resizing / shrinking the underlying input type. N.B.: I believe that if merged, this would introduce a breaking change. [`HasMutatorBytes`]: https://github.com/AFLplusplus/LibAFL/blob/198cd5dbc5200bfba3df48cf2a14376e0f0e3000/libafl/src/inputs/bytes.rs#L26
(See #2853.)
This commit attempts to improve the
HasMutatorBytestrait to allow it tobe used along with input types that cannot be resizable.
HasMutatorBytesis split into two traits:HasMutatorBytes: requiresbytesandbytes_mut.HasMutatorResizableBytes: requiresHasMutatorBytes, and also requiresa few other methods for resizing / shrinking the underlying input type.
N.B.: I believe that if merged, this would introduce a breaking change.