Remove Input associated type #2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er in most cases.
mzfr
pushed a commit
to mzfr/LibAFL
that referenced
this pull request
Jan 19, 2025
* Completely remove Input as an associated type in multiple traits * Unify usage of Input as generic instead * Remove many unused bounds, in particular HasCorpus * fix multiple generic ordering * update and fix CONTRIBUTING.md * update MIGRATION * use the same generic input type for new / with_max_iterations to make typing easier in most cases. * Restore libafl_libfuzzer test in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
until then, we were using a mix of
<S as HasCorpus>::Input: ...andI: ..., which were referring to the same thing in practice.this patch unify usage of input using a single generic
I.implications:
type Input: Inputin traits definitions that were using them, only useIgeneric instead.next step is to do the same for
ShMemProviderassociated type, and finally remove generic bounds from struct definitions.