Add Python Grammar Loader for Nautilus #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R9295
changed the title
R9295
force-pushed
the
feature/py-grammar-loader
branch
from
0e8a3c7 to
ae2eda8
Compare
R9295
commented
Oct 28, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
domenukk
reviewed
Oct 28, 2024
domenukk
reviewed
Oct 28, 2024
domenukk
reviewed
Oct 28, 2024
| @@ -109,6 +109,8 @@ impl ChunkStore { | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
| // Due to fs::create_dir_all, miri won't work | |||
There was a problem hiding this comment.
how did it work before?
Could we just skip the create_dir_all in miri and do everything else?
There was a problem hiding this comment.
Ah my bad, CI miri already uses -disable-isolation
There was a problem hiding this comment.
I have no idea why it is failing
domenukk
reviewed
Oct 28, 2024
domenukk
reviewed
Oct 28, 2024
|
@domenukk can we merge? android, ios CI is fixed now. I expect miri to pass too The frida CI fails cause auto download is now not a default feature and that's why it cannot find the headers Note: Nautilus is now an optional feature, not default |
|
Thanks for the work! <3 |
riesentoaster
pushed a commit
to riesentoaster/LibAFL
that referenced
this pull request
Dec 11, 2024
* add python grammar loader for Nautilus * fmt * fmt toml * add python to macos CI deps * install python * fmt * ci * clippy * fix workflow * fmt * fix baby nautilus * fix nautilus sync * fmt * fmt * clippy * typo * fix miri * remove pyo3 from workspace to packages which need it and make it optional * go back to AsRef<Path> for nautilus grammar loading * replace hardcoded python flags for macos build * typo * taplo fmt * revert formatting of libafl_qemu_arch * ci * typo * remove expects in NautilusContext::from_file and make them Results * remove not(miri) clause in test * try and fix python build fir ios and android * again * android * tmate * fix android build * document load_python_grammar * log if python or json when loading nautilus grammar * make nautilus optional * add nautilus as feature to forkserver_simple_nautilus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's also fix the PyO3 CI in this PR
and add a proper example