Remove all Uses* #2438

addisoncrump · 2024-07-23T14:47:45Z

Uses* constrains type definitions to a single type. This either (a) forces us to use PhantomData where we probably shouldn't, or (b) overconstrains us to the same type when it isn't necessary.

This initial PR removes all Uses*-like traits in favour of a more considered approach to type consistency.

libafl/src/events/mod.rs

libafl/src/corpus/cached.rs

libafl/src/events/mod.rs

domenukk · 2024-07-24T12:40:19Z

FWIW this is undoing #767 pretty much exactly

addisoncrump · 2024-07-24T12:54:11Z

FWIW this is undoing #767 pretty much exactly

Yup -- realised some time ago that it wasn't doing what we wanted.

libafl/src/events/centralized.rs

libafl/src/executors/mod.rs

libafl/src/feedbacks/custom_filename.rs

libafl/src/schedulers/mod.rs

domenukk · 2024-07-29T15:56:07Z

@addisoncrump if you haven't already, feel free to ignore #2442

domenukk · 2024-07-30T15:35:51Z

Low-key very excited for this #roadto1.0

addisoncrump · 2024-07-31T13:02:33Z

Note to self: HasSolutions should not require HasCorpus because a) the inputs might differ (unlikely) or b) the state may not have a corpus (for generative fuzzers).

…e handlers

addisoncrump · 2024-08-02T12:51:57Z

default features now build! (but with lots of things commented out)

* aaa * calibrate * wip * add all * last bit * a * aa * some changes * aaa * mutator DONE * aa * fix * rename * aa * aa * aa * add * fix

domenukk · 2024-08-06T15:34:49Z

libafl/src/events/mod.rs

-pub trait ProgressReporter: EventFirer
+/// Default implementation of [`ProgressReporter::maybe_report_progress`] for implementors with the
+/// given constraints
+pub fn default_maybe_report_progress<PR, S>(


std instead of default? That's our naming scheme in the repo so far (because Default is heavily abused in Rust already)

👍 Makes sense

domenukk · 2024-08-06T15:38:57Z

libafl/src/events/mod.rs

+/// [`CustomBufHandlerTuple`] in the associated `handlers` parameter for your event manager. You may
+/// then use [`SupportsDynamicHandlers::add_custom_buf_handler`].
+#[deprecated(
+    note = "Using function pointers may limit your ability to use some stages due to type conflicts regarding the state"


Why deprecate?

We should only deprecate stuff we want to drop, do we want to drop this? What's an example for such a type conflict?

Because it is both potentially restrictive and bad practice. Deprecation is the only means by which we can communicate that to both new and old codebases at compile time.

Why is it bad? If ppl want to use it and we support it we should not deprecate

Or we don't support it anymore, then we should put a version into the deprecation note and remove it later

i really want to delete this custom buf, it just offers the similar functionality as event hooks. so no reason to keep it

i really want to delete this custom buf, it just offers the similar functionality as event hooks. so no reason to keep it

If there is truly no functionality you cannot accomplish with event hooks instead, then I agree that all custom buf handlers should be removed. @domenukk for reference, you are the person who has the most use of this functionality iirc

one thing is that is possible to custombuf only is that eventhook is static. so you can not add anything at runtime.
but do you really want to add something to change the behavior of the event manager? at runtime?

I would say "no", but historically @domenukk has disagreed. Apparently some people do some strange dynamic behaviour.

Apart from being able to add and remove hooks on the fly, another benefit is that that dynamic buffers can be closures, static event hooks can not(I think?)
Capturing values takes away some headaches.
But yeah if you all want it gone we can remove it and worst case bring it back in the future...

domenukk · 2024-08-06T15:42:40Z

libafl/src/executors/command.rs

@@ -522,27 +466,25 @@ impl CommandExecutorBuilder {
            command.stderr(Stdio::piped());
        }

-        let configurator = StdCommandConfigurator {
+        let configurer = StdCommandConfigurator {


typo (or we need to change the type name too)

domenukk · 2024-08-06T15:44:41Z

libafl/src/executors/differential.rs

-    OTA: ObserversTuple<<Self as UsesState>::State>,
-    OTB: ObserversTuple<<Self as UsesState>::State>,
-    DOT: DifferentialObserversTuple<OTA, OTB, <Self as UsesState>::State>,
-{


Not really related, but can we add a // Safetly comment below on why the unsafe in fn observers is safe?

domenukk · 2024-08-06T15:45:31Z

libafl/src/executors/hooks/inprocess.rs

-        E::State: HasExecutions + HasSolutions + HasCorpus,
-        Z: HasObjective<Objective = OF, State = E::State>,
-    {
+    pub fn new<EM, I, S, Z>(exec_tmout: Duration) -> Result<Self, Error> {


libafl/src/feedbacks/mod.rs

libafl/src/mutators/tuneable.rs

libafl_bolts/src/os/unix_signals.rs

libafl/src/stages/pruning.rs

* add * 60% done? * push * new trait * add canserializeobserver * push

* add * more constraints

addisoncrump commented Jul 24, 2024

View reviewed changes

libafl/src/events/mod.rs Outdated Show resolved Hide resolved

domenukk reviewed Jul 24, 2024

View reviewed changes

libafl/src/corpus/cached.rs Show resolved Hide resolved

domenukk reviewed Jul 24, 2024

View reviewed changes

libafl/src/events/mod.rs Show resolved Hide resolved

domenukk reviewed Jul 25, 2024

View reviewed changes

libafl/src/events/centralized.rs Show resolved Hide resolved

domenukk reviewed Jul 25, 2024

View reviewed changes

libafl/src/executors/mod.rs Show resolved Hide resolved

addisoncrump commented Jul 25, 2024

View reviewed changes

libafl/src/feedbacks/custom_filename.rs Outdated Show resolved Hide resolved

domenukk mentioned this pull request Jul 26, 2024

Format all .tomls with taplo fmt #2436

Merged

domenukk reviewed Jul 26, 2024

View reviewed changes

libafl/src/schedulers/mod.rs Show resolved Hide resolved

addisoncrump mentioned this pull request Jul 29, 2024

Reduce code duplication in track_hit_feedbacks code #2444

Open

addisoncrump force-pushed the no-uses branch from c1b2d34 to 9e9053c Compare July 29, 2024 14:08

domenukk mentioned this pull request Jul 29, 2024

Update pyo3 #2459

Merged

addisoncrump added 14 commits August 1, 2024 17:29

poof uses traits

941e94a

winnow corpus

0f8dfb4

major events changes; no manager, drop lots of generics, support tupl…

404e8cf

…e handlers

simple event handlers

979fedd

simple std fixes

86e4f72

some progress on centralized; need to do executors before continuing

7193a68

simplify executors

2a7d6bc

simplify combined

f3d2a7e

simplify with_observers

0d6e85a

simplify command

f026c77

update observers, extend changes to command, diff

4adb009

supports, not has

385ec97

a little more cleanup for diff obs, forkserver

a41049a

simplify shadow

6e90c8c

addisoncrump added 4 commits August 1, 2024 17:29

simplify fuzzer (NEEDS MORE GENERIC WINNOWING)

b1a34ad

update stages

cb00aad

use @domenukk comment trick and make some progress resolving type errors

529cc5b

fixup fuzzer

65e775b

addisoncrump force-pushed the no-uses branch from 4341608 to 65e775b Compare August 1, 2024 15:31

addisoncrump added 3 commits August 1, 2024 17:34

value observer

81ddae6

it builds!

53ec398

warning cleanup

b8ac817

re-integrate trivial modules

308a2c1

addisoncrump mentioned this pull request Aug 4, 2024

Add Intel PT tracing support #2471

Merged

addisoncrump force-pushed the no-uses branch 2 times, most recently from 42670b2 to 308a2c1 Compare August 5, 2024 14:09

No uses from Mutators and Observers (#2472)

4b1bb8e

* aaa * calibrate * wip * add all * last bit * a * aa * some changes * aaa * mutator DONE * aa * fix * rename * aa * aa * aa * add * fix

domenukk reviewed Aug 6, 2024

View reviewed changes

libafl/src/feedbacks/mod.rs Show resolved Hide resolved

domenukk reviewed Aug 6, 2024

View reviewed changes

libafl/src/mutators/tuneable.rs Show resolved Hide resolved

domenukk reviewed Aug 6, 2024

View reviewed changes

libafl_bolts/src/os/unix_signals.rs Show resolved Hide resolved

domenukk reviewed Aug 6, 2024

View reviewed changes

libafl/src/stages/pruning.rs Show resolved Hide resolved

tokatoka added 2 commits August 13, 2024 15:32

No uses from EventManager (#2482)

9ffe18a

* add * 60% done? * push * new trait * add canserializeobserver * push

No uses for stages 2 (#2485)

7fff2bc

* add * more constraints

domenukk mentioned this pull request Sep 8, 2024

Feature: Make executors and feedbacks easier to use outside of the fuzzing loop #2511

Closed

tokatoka closed this Sep 20, 2024

tokatoka mentioned this pull request Sep 23, 2024

Reducing type parameters and bounds from Scheduler #2544

Merged

tokatoka mentioned this pull request Jan 12, 2025

Remove CustomBufHandlers #2829

Merged

tokatoka deleted the no-uses branch January 18, 2025 13:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove all Uses* #2438

Remove all Uses* #2438

addisoncrump commented Jul 23, 2024

domenukk commented Jul 24, 2024

addisoncrump commented Jul 24, 2024

domenukk commented Jul 29, 2024

domenukk commented Jul 30, 2024

addisoncrump commented Jul 31, 2024

addisoncrump commented Aug 2, 2024

domenukk Aug 6, 2024

addisoncrump Aug 6, 2024

domenukk Aug 6, 2024

domenukk Aug 6, 2024

addisoncrump Aug 6, 2024

domenukk Aug 6, 2024 •

edited

Loading

domenukk Aug 6, 2024

tokatoka Aug 7, 2024

addisoncrump Aug 7, 2024

tokatoka Aug 7, 2024 •

edited

Loading

addisoncrump Aug 7, 2024

domenukk Aug 7, 2024

domenukk Aug 6, 2024

domenukk Aug 6, 2024

domenukk Aug 6, 2024

Remove all Uses* #2438

Remove all Uses* #2438

Conversation

addisoncrump commented Jul 23, 2024

domenukk commented Jul 24, 2024

addisoncrump commented Jul 24, 2024

domenukk commented Jul 29, 2024

domenukk commented Jul 30, 2024

addisoncrump commented Jul 31, 2024

addisoncrump commented Aug 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

domenukk Aug 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tokatoka Aug 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

domenukk Aug 6, 2024 •

edited

Loading

tokatoka Aug 7, 2024 •

edited

Loading