Make ddg map compilation optional #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenukk
commented
Jun 26, 2024
| @@ -152,7 +152,7 @@ fn build_pass( | |||
| src_dir: &Path, | |||
| src_file: &str, | |||
| additional_srcfiles: Option<&Vec<&str>>, | |||
| optional: bool, | |||
| required: bool, | |||
There was a problem hiding this comment.
Personal preference, but when I don't see the prarameter names in the calling code and read true, I assume it's "required", not "optional" (as in, true means force it, false means be cool about it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it does not build on all systems