Implement RetryProgress for limiting retry attempts in stages
#1890
Conversation
|
Okay, small hiccup: we need the implementation of NeverResume to be generic over the type which it is used by, but the only real way to do this I can find is using the nightmare fuel syntax in the last commit.
|
addisoncrump
force-pushed
the
never-resume
branch
from
252681f to
8a1f6da
Compare
|
Resolved the issues above by simply thinking. |
addisoncrump
changed the title
libafl/src/stages/tracing.rs
Outdated
| /// Apply a certain amount of tries that this stage will attempt to trace the input before | ||
| /// giving up and not processing the input again. | ||
| #[must_use] | ||
| pub fn with_tries(mut self, initial_tries: usize) -> Self { |
There was a problem hiding this comment.
with_retries(1) would suggest that the input is run twice, not once like current behaviour.
There was a problem hiding this comment.
Would prefer that, simply because the name makes more sense (RetryStage, not TryStage)
There was a problem hiding this comment.
So, you would prefer that the value represents the number of retries? In other words, 0 retries = 1 try?
There was a problem hiding this comment.
I've just pushed this change.
|
Gah, new clippy lints. I'll just fix those now... |
|
Looks good! Some last clippy things and I proposed some name changes -> feel free to accept or discard, then merge :) |
domenukk
changed the title
RetryProgress for limiting retry attempts in stages
Addresses a scenario where comparison log tracing never completes as it gets stuck in a timeout loop.