Rework Frida instrumentation to decouple it from FuzzerOptions and add FridaInstrumentationHelperBuilder #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfreyer
force-pushed
the
feat/rework-frida-helper
branch
3 times, most recently
from
bd47c07 to
de7d12f
Compare
Instead, keep the actual values that are needed. This allows us to make a builder for FridaInstrumentationBuilder in a subsequent commit.
This is just code movement.
Mostly code movement here, sets up replacing `new` with a builder. The one exception is the introduction of a lifetime bound on RT, which needs to outlive the transformer. This could be generic, but there's probably no reason to introduce an additional lifetime. However, because of this lifetime introduction, this is _technically_ a breaking change.
Instead of passing a slice of modules to instrument, and re-building the modulemap, pass a Ref-counted module map directly to the initialization.
fabianfreyer
force-pushed
the
feat/rework-frida-helper
branch
3 times, most recently
from
0e729f0 to
c84b16b
Compare
fabianfreyer
force-pushed
the
feat/rework-frida-helper
branch
3 times, most recently
from
61fc9db to
ff6e06e
Compare
Co-authored-by: Dominik Maier <[email protected]>
Move all the initialization into Default::default with sensible defaults and override parameters set from options in new.
The only option AsanError uses is whether to continue on error. Instead of keeping a whole clone of the options around, just store that single boolean value.
* Implement Default::default to get a good default AsanRuntime
fabianfreyer
force-pushed
the
feat/rework-frida-helper
branch
from
ff6e06e to
05e57f2
Compare
fabianfreyer
changed the title
fabianfreyer
changed the title
|
Thank you! |
|
Sorry didn't get a chance to review till now. Looks good! |
domenukk
pushed a commit
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Frida helper is very dependent on using the FuzzerOptions from
libafl_bolts. However, there is no reason it has to be, and Frida mode should totally be usable without needing clap or the like.