Apparently cargo:error does nothing
#1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! Can you please run @addisoncrump what's needed for MacOS? I though it was working-ish? Linking issues? |
|
Sadly, there are still some issues w.r.t. weak linkage that need to be resolved. This is a good catch though. |
elnardu
force-pushed
the
fix-cargo-error-macos
branch
from
02eed89 to
e015df1
Compare
It is very confusing if you are trying to build on MacOS and it is telling you that it worked, but actually it didn't.
elnardu
force-pushed
the
fix-cargo-error-macos
branch
from
e015df1 to
2f20a42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very confusing if you are trying to build on MacOS and it is telling you that it worked, but actually it didn't.