Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making custom SSL configuration possible #555

Closed
wants to merge 1 commit into from
Closed

Making custom SSL configuration possible #555

wants to merge 1 commit into from

Conversation

karolszklarski
Copy link

  • Adding new configuration option - setSSLConfigFactoryClass
  • This class will be used in HttpRequest class to setup httpsUrlConnection
  • DefaultSSLConfig class contains code moved from original HttpRequest

@F43nd1r
Copy link
Member

F43nd1r commented Mar 3, 2017

I think instead of providing yet another configuration factory, it would be better to increase the flexibility of the existing HttpSender & HttpRequest. I have thrown together a simple solution in #557

@F43nd1r F43nd1r closed this Mar 3, 2017
@F43nd1r
Copy link
Member

F43nd1r commented Mar 3, 2017

Closed in favor of #557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karolszklarski @F43nd1r