-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android 8, ACRA 4.10.0. No Notification when ReportingInteractionMode is NOTIFICATION #597
Comments
Yes, it requires channels. To use channels, we'd have to use support libraries with version 26.0.0+ |
I think a base of API 15 (Ice Cream Sandwich) is reasonable nowadays. |
Can't it also be achieved without the support lib? You would obviously need to set compile SDK to 26 and do API level check and use 26 API for channels |
I was working on a modularized version of acra anyways, and that structure allows for different minSdk versions for different modules. So, I created a notification module, which you can test using the following: build.gradle: dependencies {
compile 'com.faendir.acra:acra-http:5.0.0-alpha4'
compile 'com.faendir.acra:acra-notification:5.0.0-alpha4'
} MyApplication.java: @AcraCore(buildConfigClass = BuildConfig.class)
@AcraHttpSender(
uri = "https://192.168.0.200/acra",
basicAuthLogin = "***",
basicAuthPassword = "***",
httpMethod = HttpSender.Method.POST,
reportType = HttpSender.Type.JSON)
@AcraNotification(
resTitle = R.string.title,
resText = R.string.text,
resChannelName = R.string.app_name,
resCommentPrompt = R.string.comment) And the |
Cool, it seems to have min skd 16. I have 15. I am going to use tools:overrideLibrary="org.acra.notification" to force usage. Do you think you have any API usage that isn't on 15? |
MinSdk is on 16 because notification buttons aren't shown on 15 and below, and there is no fallback (yet). (In case you haven't noticed, instead of bringing up a dialog as the old notification did, this just lets the user interact with the notification directly) I think a reasonable fallback would be to just let users on old devices click the notification to send the report, still thinking about other possibilites. |
I've pushed alpha5 with minSdk 14, fallback is as written above |
I get below on Android 7. Related to https://stackoverflow.com/questions/36428868/proguard-with-autovalue?? Proguard log [editors note: hidden block because of length]
|
Proguard doesn't like autoservice to be compiled in the project. I changed the scope to provided, because it isn't used at runtime anyways. I uploaded After this size reduction the minimal(maximal) useful configuration is 29%(11%) smaller than version 4.10 |
I am doing this correctly? Here is my old config @ReportsCrashes( mode = ReportingInteractionMode.NOTIFICATION, ) and here is the new config @AcraNotification( ) ) |
Does the notification disappear?
Your config looks good. |
Does not disappear. Just stays there.
|
Have you tried alpha7? I've fixed several edge cases there. |
I've uploaded some images showcasing the notification ( Config used: @AcraNotification(
resTitle = R.string.title,
resText = R.string.text,
resChannelName = R.string.app_name,
resSendButtonText = R.string.button_send,
resDiscardButtonText = R.string.button_discard,
resSendWithCommentButtonText = R.string.button_send_with_comment,
resCommentPrompt = R.string.comment,
resOkToast = R.string.toast_text) resources: <resources>
<string name="app_name">AcraTest</string>
<string name="title">Crash</string>
<string name="text">AcraTest crashed. Please send a report to support development.</string>
<string name="comment">Enter comment here</string>
<string name="toast_text">Report has been sent.\nThanks!</string>
<string name="button_send_with_comment">Send with comment</string>
<string name="button_send">Send</string>
<string name="button_discard">Discard</string>
</resources> |
Thank you it seems to be OK. However, how would one define the email address that will ACRA use to send? |
Use and @AcraMailSender(mailTo="[email protected]") |
Works great! May I suggest a small enhancement? AS a user I would expect something happening when notification touched. Perhaps send action? I understand you already have Send and Cancel Actions already but I m pretty sure most people would tap on the notification itself. |
I like it better the way it is now. I'll implement a toggle option though.
2017-09-23 20:53 GMT+02:00 NLL APPS <[email protected]>:
… Works great! May I suggest a small enhancement? AS a user I would expect
something happening when notification touched. Perhaps send action? I
understand you already have Send and Cancel Actions already but I m pretty
sure most people would tap on the notification itself.
Thank you for quick responses .
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#597 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJxxpJf0OzlH0URW0wPKz-Fn9OlExT1Iks5slVPAgaJpZM4PYMWp>
.
|
I implemented that toggle in alpha8+ |
Thanks very much. Is there a sample configuration? |
Also getting following crash on app start on alpha8
|
Use alpha 11, Service loading should be fixed there. Usage: @AcraNotification(
//...
sendOnClick = true) |
Thanks. I get following on 11
|
|
Yes WARN. `@AcraMailSender( @AcraNotification( ) @acracore( |
Thanks, will be fixed in next version. I've seen you are using |
I usually skim thorough my inbox and delete repeat3d reports. Having the report part of the email saves alot of extra clicks
|
As per title. Looks like only happens when projects build and target sdk is 26 (i think)
Does it need notification channels https://developer.android.com/about/versions/oreo/android-8.0.html#notifications ?
The text was updated successfully, but these errors were encountered: