Add test class for ACCESS-ESM1.6

[dougiesquire]

Adds an ACCESS-ESM1.6 test class for use with the new ACCESS-ESM1.6 Payu driver. Closes #121

[dougiesquire]

I'll update the tests next week

[dougiesquire]

Also, do we want to address this first/now: #123

[blimlim]

Also, do we want to address this first/now: #123
I think adding the test class first and then working out the repro tests after sounds good!

[codecov]

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.21%. Comparing base (87a8341) to head (b5e995f).
Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
src/model_config_tests/models/accessesm1p5.py	66.66%	1 Missing ⚠️
src/model_config_tests/models/accessom2.py	66.66%	1 Missing ⚠️
src/model_config_tests/models/accessom3.py	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   74.94%   75.21%   +0.27%     
==========================================
  Files          17       18       +1     
  Lines         906      916      +10     
==========================================
+ Hits          679      689      +10     
  Misses        227      227              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dougiesquire]

I think adding the test class first and then working out the repro tests after sounds good!

Sounds good, thanks @blimlim. Tests fixed and ready for review then

[jo-basevi]

Looks good to me

All the test resources files might not be needed at the moment - were they added pre-emptively for future tests? For the tests for parsing checksums (tests/test_model_extract_checksums.py), I think it just requires the following test resources to work:

• tests/resources/access-esm1.6/checksums/1-0-0.json
• tests/resources/access-esm1.6/output000/access-esm1.6.out

Could add the dev-preindustrial+concentrations to this parametrised test? I think it would need just the config.yaml file as well.

model-config-tests/tests/test_test_bit_reproducibility.py

Lines 225 to 236 in 123dd16

	@pytest.mark.parametrize(
	"model_name, output_0, configuration",
	[
	("access", "output000", None),
	("access", "output000", "release-preindustrial+concentrations"),
	("access-om2", "output000", "release-1deg_jra55_ryf"),
	("access-om3", "restart000", "om3-dev-1deg_jra55do_ryf"),
	("access-om3", "restart000", "om3-wav-dev-1deg_jra55do_ryf"),
	],
	)
	@pytest.mark.parametrize("fail", [False, True])
	def test_test_bit_repro_historical(tmp_dir, model_name, output_0, configuration, fail):

[blimlim]

Thanks @dougiesquire for fixing this up! Looks all good to me

[dougiesquire]

All the test resources files might not be needed at the moment - were they added pre-emptively for future tests?

Good point. I just copied the access-esm1.5 test config but didn't actually notice the access-esm1.6 qa check tests were commented out and not actually testing anything. I've removed the access-esm1.6 test configuration for now until we have a release- config to use (by that point we'll possibly have removed the tests/resources folder anyway)

Could add the dev-preindustrial+concentrations to this parametrised test? I think it would need just the config.yaml file as well.

As above, I've now remove the dev-preindustrial+concentrations test config, but access-esm1.6 is now being tested as part of test_test_bit_repro_historical.

Sorry, could I get a re-approval from one of you @jo-basevi, @blimlim

[jo-basevi]

Thanks @dougiesquire - LGTM