Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow delegate to customise dimmer cutout height without custom CAShape #366

Conversation

vpopovyc
Copy link

@vpopovyc vpopovyc commented Nov 7, 2019

I had case when Drawer provided puller tip at the top of drawer body with transparent background. In result I get something like this:

IMG_4969

I know there is an option to make custom shape, but I thought that delegating that stuff to a drawer could be a nice idea.

IMG_4968

@ulmentflam
Copy link
Contributor

ulmentflam commented Oct 9, 2020

@vpopovyc Thanks for your PR! At this time I am not going to merge it into master, as I don't believe this is the approach we want to take for customizing the cutout and can support your desired use case in other ways like constraining the top of your gripper to the top of the drawer instead and modifying the top inset of the drawer when .open.

@ulmentflam ulmentflam closed this Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants