Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liquid modules #84

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Liquid modules #84

wants to merge 7 commits into from

Conversation

Oskal174
Copy link
Collaborator

3xpl modules for Liquid blockchain.
UTXOMainModule was improved with new feature.
Additional module for Liquid assets (it works with off-chain api only).

@Oskal174 Oskal174 requested a review from Har01d as a code owner March 20, 2024 07:17
Har01d
Har01d requested changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@Har01d Har01d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be combined into one module. Also, null assets seem to be unknown (confidential) assets, rather than the native asset (L-BTC).

@Har01d Har01d self-requested a review March 29, 2024 19:43
Har01d
Har01d previously approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@Har01d Har01d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working fine with the fixes: https://3xpl.com/liquid-network

@Har01d
Copy link
Collaborator

Har01d commented Mar 29, 2024

The only thing that doesn't check out is the balance of the-bridge. It shows as 3848.90272308 L-BTC while other explorers report the circulating amount as 3840.20023942. Could this be connected to 4d32977? @Oskal174

@Har01d Har01d self-requested a review March 29, 2024 19:48
@Har01d Har01d dismissed their stale review March 29, 2024 19:49

Probably a bug in peg-in processing

@alexqrid
Copy link
Collaborator

alexqrid commented Apr 4, 2024

The only thing that doesn't check out is the balance of the-bridge. It shows as 3848.90272308 L-BTC while other explorers report the circulating amount as 3840.20023942.

Tried to get some clarification from the liquid team.

@Har01d Har01d assigned alexqrid and unassigned Oskal174 Apr 19, 2024
@Har01d Har01d requested a review from alexqrid April 19, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Har01d Har01d Awaiting requested review from Har01d Har01d is a code owner

@alexqrid alexqrid Awaiting requested review from alexqrid

At least 1 approving review is required to merge this pull request.

Assignees

@Har01d Har01d

@alexqrid alexqrid

Labels
Add blockchain Beta test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oskal174 @Har01d @alexqrid