-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transaction ordering in Beacon Chain #78
base: main
Are you sure you want to change the base?
Conversation
public ?TransactionHashFormat $transaction_hash_format = TransactionHashFormat::None; | ||
public ?TransactionRenderModel $transaction_render_model = TransactionRenderModel::None; | ||
public ?TransactionHashFormat $transaction_hash_format = TransactionHashFormat::AlphaNumeric; | ||
public ?TransactionRenderModel $transaction_render_model = TransactionRenderModel::Mixed; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be reverted, see 7c879b1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can u please help me I only just seen this messsge sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And how do I do that sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the code comment
@jzethar Look through this PR please, and rebase onto main branch |
In this PR, there are some fixes to address event ordering issues. The primary problem was that multicurl doesn't inherently guarantee order, which led to data corruption (the same block could return events in different sequences). This issue has been resolved in the affected modules.
For more details on the original problem, please refer to the following issue.