Fix transaction ordering in Beacon Chain #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Har01d
changed the title
Har01d
reviewed
Feb 6, 2024
| public ?TransactionHashFormat $transaction_hash_format = TransactionHashFormat::None; | ||
| public ?TransactionRenderModel $transaction_render_model = TransactionRenderModel::None; | ||
| public ?TransactionHashFormat $transaction_hash_format = TransactionHashFormat::AlphaNumeric; | ||
| public ?TransactionRenderModel $transaction_render_model = TransactionRenderModel::Mixed; |
There was a problem hiding this comment.
This should be reverted, see 7c879b1
There was a problem hiding this comment.
Can u please help me I only just seen this messsge sorry
Gosling74
approved these changes
May 21, 2024
|
@jzethar Look through this PR please, and rebase onto main branch |
Gosling74
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, there are some fixes to address event ordering issues. The primary problem was that multicurl doesn't inherently guarantee order, which led to data corruption (the same block could return events in different sequences). This issue has been resolved in the affected modules.
For more details on the original problem, please refer to the following issue.