Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transaction ordering in Beacon Chain #78

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jzethar
Copy link
Collaborator

@jzethar jzethar commented Feb 5, 2024

In this PR, there are some fixes to address event ordering issues. The primary problem was that multicurl doesn't inherently guarantee order, which led to data corruption (the same block could return events in different sequences). This issue has been resolved in the affected modules.
For more details on the original problem, please refer to the following issue.

@jzethar jzethar requested a review from Har01d as a code owner February 5, 2024 18:30
@Har01d Har01d changed the title fix transaction ordering Fix transaction ordering in Beacon Chain Feb 6, 2024
public ?TransactionHashFormat $transaction_hash_format = TransactionHashFormat::None;
public ?TransactionRenderModel $transaction_render_model = TransactionRenderModel::None;
public ?TransactionHashFormat $transaction_hash_format = TransactionHashFormat::AlphaNumeric;
public ?TransactionRenderModel $transaction_render_model = TransactionRenderModel::Mixed;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reverted, see 7c879b1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can u please help me I only just seen this messsge sorry

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And how do I do that sorry

Copy link
Collaborator

@Har01d Har01d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the code comment

@alexqrid
Copy link
Collaborator

@jzethar Look through this PR please, and rebase onto main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beacon Chain deposits, withdrawals, and penalties are in random order within an epoch
4 participants