-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to better conform to WP Coding Standards #120
Conversation
@bmarshall511 I confirmed here that the tests pass on |
09dcd6e
to
60f85ef
Compare
@Sidsector9 Fixed the failing test. There's still a handful of files that still need to be touched to better conform to standards, but leaving as is for now until #117 gets merged to avoid a bunch of potential conflicts. Side note, this handles about 90% of the coding standard errors. There's still some that'll require a larger lift (i.e restructuring classes, adding nonces, renaming hooks, etc.), but probably better to handle those in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's no problem, we can handle the remaining 10% in a separate PR. Thanks for fixing the tests 👍
@Sidsector9 Got this updated with |
Description of the Change
Lots of code updates to better conform to WordPress Coding Standards.
Closes #118
How to test the Change
Changelog Entry
Credits
Props @bmarshall511
Checklist: