Update all actions we use in our workflows to pull from specific pinned commits #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffpaul
reviewed
Mar 18, 2025
| - name: Annotate code linting results | ||
| uses: ataylorme/eslint-annotate-action@1.2.0 | ||
| uses: ataylorme/eslint-annotate-action@5f4dc2e3af8d3c21b727edb597e5503510b1dc9c # v2.2.0 |
There was a problem hiding this comment.
Looks like some interesting updates in the 3.0.0 release, but definitely a concern for a different day/PR
There was a problem hiding this comment.
Yeah... I debated going to 3.0.0 but with the noted breaking changes there, decided it might be better to handle that separately (though it may just work without any needed changes on our end)
jeffpaul
previously approved these changes
Mar 18, 2025
|
Some E2E failures here but does not seem related to the changes in this PR. I think I may wait until #1302 gets merged in (as that PR fixes some existing failures) to see if that fixes things here |
faisal-alvi
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In order to help protect against compromised actions, instead of including actions based on their major version (like v4), this PR switches all the actions we use to pull based on the commit hash from the latest release.
While this does impact maintenance a bit going forward, it ensures that we we're always using actions that we (hopefully) trust and if an action gets compromised (which happens) we don't have to worry that we're using a compromised action. This also goes along with what GitHub suggests.
How to test the Change
Ensure all our workflows still run as expected
Changelog Entry
Credits
Props @dkotter, @jeffpaul
Checklist: