Pull screen search feature #1256
Conversation
kirtangajjar
requested review from
peterwilsoncc
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
assets/js/admin-pull.js
Outdated
| ); | ||
| const dropdown = container.querySelector( '.searchable-select__dropdown' ); | ||
|
|
||
| const itemss = await fetch( '/wp-admin/admin-ajax.php', { |
There was a problem hiding this comment.
Typeo? If it's meant to be searchResults or similar then use the longer name for clarity.
| const itemss = await fetch( '/wp-admin/admin-ajax.php', { | |
| const items = await fetch( '/wp-admin/admin-ajax.php', { |
There was a problem hiding this comment.
Improved the name of var
assets/js/admin-pull.js
Outdated
|
|
||
| function filterItems( searchTerm ) { | ||
| const filteredItems = itemss.filter( ( item ) => | ||
| item.toLowerCase().includes( searchTerm.toLowerCase() ) |
There was a problem hiding this comment.
I'm getting an error on this line as item is an object:
{
"id": "2",
"name": "ms-distributor.local/two",
"url": "ms-distributor.local/two",
"pull_url": "http://ms-distributor.local/wp-admin/admin.php?page=pull&connection_type=internal&connection_id=2",
"type": "internal"
}
There was a problem hiding this comment.
Yupp, fixed it now.
includes/pull-ui.php
Outdated
| 'name' => untrailingslashit( $internal_connection->site->domain . $internal_connection->site->path ), | ||
| 'url' => untrailingslashit( preg_replace( '#(https?:\/\/|www\.)#i', '', get_site_url( $internal_connection->site->blog_id ) ) ), |
There was a problem hiding this comment.
I'm a little unclear why name and URL are using the same (or at least similar ) values. site->domain . site->path ought to resolved to get_site_url().
Although we don't display the name, it may be helpful to allow people to search by the name, so a search for Make WordPress Core would return make.wordpress.org/core
There was a problem hiding this comment.
Good idea, added name and URL as separate things and showed them both on FE as well.
includes/push-ui.php
Outdated
| add_action( 'wp_ajax_dt_load_connections', __NAMESPACE__ . '\get_connections' ); | ||
| add_action( 'wp_ajax_dt_load_connections_push', __NAMESPACE__ . '\get_connections' ); |
There was a problem hiding this comment.
I'm assuming this is for clarity from wp_ajax_dt_load_connections_pull?
We're probably stuck with the old name to ensure backward compatibility with the third party extensions and between different versions of the plugin. Otherwise we could go through a soft deprecation.
There was a problem hiding this comment.
Thanks for pointing it out. I've added the old method back with soft deprecation. LMK if I did it correctly(this is my first time doing it)
|
@peterwilsoncc I've addressed your feedback. LMK if you find anything else. |
|
These changes look good, thank you. This is looking good, I'm seeing a bug on the pull screen when there are two connections with the same ID (ie an external connection's POST ID matches the network connection's SITE ID). I'm seeing that selecting the external site is showing the internal site in the drop down following a refresh:
In the gif you'll see I am selecting |
Description of the Change
Add ability to search for a site on the Pull Content screen
Closes #1235
How to test the Change
Changelog Entry
Credits
Props @kirtangajjar
Checklist: