[FEATURE] Relier le composant transitoire à la page de fin de parcours et à la modal du tab "Formation"(PIX-17016) #11827
+251
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
er-lim
force-pushed
the
PIX-17016-display-sent-result-modal
branch
2 times, most recently
from
ec3aeb5 to
48acf8b
Compare
dianeCdrPix
force-pushed
the
PIX-17016-display-sent-result-modal
branch
2 times, most recently
from
e36475d to
b4024ce
Compare
er-lim
force-pushed
the
PIX-17016-display-sent-result-modal
branch
from
b4024ce to
af020cb
Compare
dianeCdrPix
force-pushed
the
PIX-17016-display-sent-result-modal
branch
from
4dc000e to
714d36f
Compare
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
er-lim
force-pushed
the
PIX-17016-display-sent-result-modal
branch
from
714d36f to
17afbf5
Compare
er-lim
force-pushed
the
PIX-17016-display-sent-result-modal
branch
from
17afbf5 to
bbb8b2a
Compare
er-lim
force-pushed
the
PIX-17016-display-sent-result-modal
branch
from
5853f3f to
20c5e58
Compare
clemlatz
approved these changes
Mar 28, 2025
mon-pix/app/components/campaigns/assessment/results/evaluation-results-tabs/index.gjs
Show resolved
Hide resolved
mon-pix/app/components/routes/campaigns/assessment/evaluation-results.gjs
Show resolved
Hide resolved
| featureToggles = { isModalSentResultEnabled: true }; | ||
| } | ||
| this.owner.register('service:featureToggles', FeatureTogglesStub); | ||
| this.model.trainings = [ |
There was a problem hiding this comment.
suggestion: on pourrait factoriser la génération des trainings dans une méthode privée pour alléger la lecture du test car au final tous les détails n'impactent pas la réussite test
There was a problem hiding this comment.
Dans un beforeEach, qu'en penses-tu ?
Co-authored-by: Clément Latzarus <[email protected]>
Co-authored-by: Eric Lim <[email protected]>
in feature-toggles config Co-authored-by: Eric Lim <[email protected]>
in modal and service Co-authored-by: Eric Lim <[email protected]>
in quit-results Co-authored-by: Yann Bertrand <[email protected]> Co-authored-by: Eric Lim <[email protected]>
in sent results modal Co-authored-by: Diane Cordier <[email protected]> Co-authored-by: Eric Lim <[email protected]>
by adding not sending results learners in EDUSIMPLE campaign
pix-service-auto-merge
force-pushed
the
PIX-17016-display-sent-result-modal
branch
from
20c5e58 to
c08f960
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌸 Problème
La modale de fin de parcours existe mais n'est pas affichée quand on envoie ses résultats.
🌳 Proposition
Afficher la modal de fin de parcours quand on envoie ses résultats. Quand on clique sur "Fermer et voir mes résultats", on retourne à la page avec les résultats et les récompenses.
🐝 Remarques
<PixModal>a été extrait du blocif/elseafin d'éviter la destruction de cette modal lorsque on partage les résultats de campagne. Ainsi, la modale ne se détruisant pas, le modifier trap-focus n'appelle pas son destructor dont le rôle est de rajouter un scroll sur la page.EvaluationResultsHero-> dans un autre ticketisModalSentResultEnabled🤧 Pour tester
J'envoie mes résultats