Dynamic.DynamicIndex is exposed in the expression

[hazzik]

After upgrading from 1.1.8 to 1.2.0 I'm getting MethodNotSupported exception because my expression parser finds Dynamic.DynamicIndex(object, string) method in the expression. Strangely this method was introduced in 1.1.8, but the error started happening only in 1.2.0

Here are the failing tests: https://ci.appveyor.com/project/hazzik/nhibernate-core/builds/35962348/job/uvi4bg3jew1giw41/tests

[StefH]

Hello @hazzik, thanks for reporting.

I'll take a look.

[StefH]

@hazzik
Can you provide a full source code example which displays this error?

[hazzik]

It is here:

https://github.com/nhibernate/nhibernate-core/blob/d6e054f2bbfda43fccf82d54b7cda4e5aecbab5d/src/NHibernate.Test/NHSpecificTest/NH2664Dynamic/Fixture.cs#L75-L88

public class Product
{
    public virtual string ProductId { get; set; }

    public virtual dynamic Properties { get; set; }
}

public void Query_DynamicComponent()
{
    using (var session = OpenSession())
    {
        var product = session
            .Query<Product>()
            .Where("Properties.Name == @0", "First Product") // <-- here
            .Single();

        Assert.That(product, Is.Not.Null);
        Assert.That((object) product.Properties["Name"], Is.EqualTo("First Product"));
        Assert.That((object) product.Properties.Name, Is.EqualTo("First Product"));
    }
}

[hazzik]

This is the simplest reproduction: https://dotnetfiddle.net/8Az1F6

It outputs

Product[].Where(Param_0 => (DynamicIndex(Param_0.Properties, "Name") == Convert("First Product", Object)))

And DynamicIndex method call is a problem here, because I would need to make NHibernate aware of this method to correctly parse the expression on 1.2.0

[StefH]

Hello @hazzik,
I think I found a possible fix for this issue, however I want to test this using NHibernate.
Can you please provide me with a minimal console-app which can reproduce this issue?

[StefH]

Dear @hazzik , can you please provide a minimal console-app to reproduce this issue?

[hazzik]

I'll do it on or by this weekend.

[hazzik]

@StefH here is the console app with reproduction: https://github.com/hazzik/nhibernate-linq-dynamic

[StefH]

@hazzik Thank you very much, I'll copy this example to verify/reproduce the bug.

[StefH]

I'm working on a fix, but dynamic cannot be supported.

This is also not supported in normal code:

The code is reworked that this scenario can work:

class Product
	{
		public virtual Guid Id { get; set; }
		public virtual string Name { get; set; }
		public virtual IDictionary<string, object> Properties { get; set; }   // <--
	}

with:

var properties1 = new Dictionary<string, object>
{
	["Name"] = "First Product",
	["Description"] = "First Description"
};
session.Save(
	new Product
	{
		Id = Guid.NewGuid(),
		Properties = properties1
	});

//var properties2 = new
//{
//	Name = "Second Product",
//	Description = "Second Description"
//};
//session.Save(
//	new Product
//	{
//		Id = Guid.NewGuid(),
//		Properties = properties2
//	});

dynamic properties3 = new ExpandoObject();
properties3.Name = "Third Product";
properties3.Description = "Third Description";
session.Save(
	new Product
	{
		Id = Guid.NewGuid(),
		Properties = properties3
	});

And this works:

var x = session.Query<Product>().Where(p => p.Properties["Name"] == "First Product").ToList();

				var y = session.Query<Product>()
					.Where("Properties.Name == @0", "First Product")
					.ToList();

[hazzik]

I'm working on a fix, but dynamic cannot be supported.

This code was working fine in 1.1.8. I know that dynamic expressions are supported in the linq-tree, but not supported on a language level. To properly support them it would probably be required to depend on Microsoft.CSharp package.

[StefH]

@hazzik
I did test previous versions.

However it seems that 1.1.7 does work, and higher versions fail with:
Unhandled exception. System.NotSupportedException: System.Object DynamicIndex(System.Object, System.String)

Correct ?

[hazzik]

Yes, that is correct. I might misremembered the working version due it is being long time since I've tested it myself.

[StefH]

Can you try

https://www.myget.org/feed/system-linq-dynamic-core/package/nuget/System.Linq.Dynamic.Core/1.2.8-preview-01

[StefH]

Hello @hazzik , did you have time to test this preview package?

[hazzik]

Seems to be working:

• https://ci.appveyor.com/project/nhibernate/nhibernate-core/builds/37695599
• https://travis-ci.org/github/nhibernate/nhibernate-core/builds/758298116?utm_source=github_status&utm_medium=notification

Thanks

[StefH]

Hello @hazzik,

Thanks a lot for your analysis and help.

In some day(s) , I'll merge this PR and create a new official 1.2.8 NuGet package