Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in IDynamicLinkCustomTypeProvider name #438

Closed
glopesdev opened this issue Oct 26, 2020 · 3 comments
Closed

Typo in IDynamicLinkCustomTypeProvider name #438

glopesdev opened this issue Oct 26, 2020 · 3 comments
Assignees
@StefH
Labels
bug

Comments

@glopesdev
Copy link
Contributor

This might well be an annoying breaking change now, but just for future reference there might be a typo in the name of IDynamicLinkCustomTypeProvider. All the other concrete types use the correct spelling Linq while this one uses Link.

No complaints here, but just wanted to flag the inconsistency between type names.
@StefH
Copy link
Collaborator

StefH commented Oct 27, 2020

@glopesdev Good catch ;-)

Best would be to add the correct class IDynamicLinqCustomTypeProvider and let the older interface extend this one in order to maintain backward compatibility.

@StefH StefH self-assigned this Jan 20, 2021
@StefH
Copy link
Collaborator

StefH commented Jan 20, 2021

#476

@StefH StefH added the bug label Jan 27, 2021
@StefH StefH changed the title Typo in custom type provider interface name Typo in IDynamicLinkCustomTypeProvider name Apr 4, 2021
@StefH
Copy link
Collaborator

StefH commented Apr 4, 2021

Changed interface name will be included in next version.

@StefH StefH closed this as completed Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefH StefH

Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StefH @glopesdev