Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues installing #105

Open
chadoh opened this issue Nov 13, 2024 · 2 comments
Open

Issues installing #105

chadoh opened this issue Nov 13, 2024 · 2 comments

Comments

@chadoh
Copy link

chadoh commented Nov 13, 2024

This is the first touch point of developers trying out Starknet, so it's important to get it right. Here's what happened when I tried to install Starkliup on macOS using zsh:

curl https://get.starkli.sh | sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:--100  4571  100  4571    0     0  14531      0 --:--:-- --:--:-- --:--:-- 14557
Installing starkliup...
#=#=#                                                          ######################################################################## 100.0%

Shell detection variables (for debugging use):
- ZSH_NAME =
- FISH_VERSION =
- SHELL = /bin/zsh

starkliup: could not detect shell. Add '. /Users/chadoh/.starkli/env' to your shell profile (or '. /Users/chadoh/.starkli/env-fish' if you're using Fish), or manually add '/Users/chadoh/.starkli/bin' to your PATH environment variable.

That "could not detect shell" line near the end seemed like an error message. I thought maybe it was telling me to try again with SHELL=/bin/zsh (assumed it was just showing an example), and tried again. Same message:

SHELL=/bin/zsh curl https://get.starkli.sh | sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:--100  4571  100  4571    0     0  21124      0 --:--:-- --:--:-- --:--:-- 21162
Installing starkliup...
######################################################################## 100.0%

Shell detection variables (for debugging use):
- ZSH_NAME =
- FISH_VERSION =
- SHELL = /bin/zsh

starkliup: could not detect shell. Add '. /Users/chadoh/.starkli/env' to your shell profile (or '. /Users/chadoh/.starkli/env-fish' if you're using Fish), or manually add '/Users/chadoh/.starkli/bin' to your PATH environment variable.

Then I thought "well hey I guess maybe it works" so I opened my .zshrc to add the recommended line, only to find it had already been added, albeit at the end of the previous line, rather than on its own line. Why bother telling me if you're going to do it for me?

And why output all this stuff that makes it seem like there were errors when it seems like maybe everything is fine?

@xJonathanLEI
Copy link
Owner

Thanks for reporting. This looks like an issue with the shell detection script. I will look into this.

@knightfoxapps
Copy link

same issue. Has there beein any development? I am on MacOS with Apple CPU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants