Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not pass 'auth' to apiinfo.version #18

Closed
richlv opened this issue Nov 28, 2016 · 4 comments
Closed

do not pass 'auth' to apiinfo.version #18

richlv opened this issue Nov 28, 2016 · 4 comments
Assignees

Comments

@richlv
Copy link
Collaborator

richlv commented Nov 28, 2016

for apiinfo.version, 'auth' must be excluded, otherwise : "Error: The "apiinfo.version" method must be called without the "auth" parameter"

it is probably worth having a special-case hack in zabbix::tiny, so that it is able to work with all the old versions of zabbix, even if this is changed in later zabbix versions.

@whosgonna
Copy link
Owner

Would it be OK as a separate method? Instead of $zabbix->do('ap info.version'), have it be $zabbix->version() ? It might even be possible to pass a separate URL here.

Part of the complexity that I see is that Zabbix::Tiny is designed to take the user and password as semi-required attributes (possibly hard required, I'll have to check the code), so creating a special handling within the do arguments is more complex than just a separate method. It does create more special handling by the user of the module, though.

@richlv
Copy link
Collaborator Author

richlv commented Dec 1, 2016

yeah, i think a separate method would be completely fine

@whosgonna
Copy link
Owner

This should be fixed in 9d5f111. I may try to find a few other minor issues (type-o's in POD, increment the version, add a few general case tests, etc.) prior to pushing to CPAN, but there shouldn't be any other logical changes prior to pushing to CPAN.

@whosgonna whosgonna self-assigned this Dec 18, 2016
@whosgonna
Copy link
Owner

Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants