Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Using sirv will cause the rsdoctor client HMR to fail #694

Closed
easy1090 opened this issue Jan 13, 2025 · 0 comments · Fixed by #737
Closed

[Bug]: Using sirv will cause the rsdoctor client HMR to fail #694

easy1090 opened this issue Jan 13, 2025 · 0 comments · Fixed by #737
Assignees

Comments

@easy1090
Copy link
Contributor

Version

@rsdoctor/* @0.4.12 and change the server-static to sirv.

Details

When change the server-static to sirv.

This affects our development, and we can't develop it with the help of hmr. After hmr, the hash changed resources will failed to be fetch.

Image

Reproduce link

Just use the rsdoctor repo.

Reproduce Steps

  1. @rsdoctor/client & @rsdoctor/sdk change the server-static to sirv
  2. pnpm i
  3. Run pnpm run dev on packages/components and run pnpm run start on packages/client.
  4. Run pnpm run start:analysis on examples/modern-minimal
  5. change some code on components to reduce the hmr.
  6. reload the examples's rsdoctor report page, will find the website crash.
@chenjiahan chenjiahan self-assigned this Jan 13, 2025
@chenjiahan chenjiahan changed the title [Bug]: sirv will reduce the rsdoctor client hmr failed [Bug]: Using sirv will cause the rsdoctor client HMR to fail Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants