Upgrade from 0.30.0 to 0.31.1 breaks dynamic import

[louisgv]

I have some express route that I'm dynamically importing using the snippet below:

import { Router } from "express"

const routeModulePaths = [
  "auth",
  "user",
  "ping",
  // 30+ more routes
]

export const setupApiRoutes = async () => {
  const router = Router()

  await Promise.all(
    routeModulePaths.map((path) =>
      import(`./${path}`).then((m) => router.use("/", m.default))
    )
  )

  return router
}

[email protected] worked, the dist contains multiple index.js files (18.index.js, 276.index.js, etc...), which I assumed was ncc splitting the bundles.

[email protected] didn't work. It produces a single index.js file, and upon running it throws this error:

Cannot find module './auth'
Require stack:

• /app/dist/index.js Error: Cannot find module './auth'

I wonder if the change to how tsconfig is further leveraged on the bundling process has anything to do with this :-?...

[PaulRBerg]

The same issue with [email protected] caused a bug in my tool create-eth-app. I'm loading a file called gitignore only if condition is met:

https://github.com/paulrberg/create-eth-app/blob/fa2d2771f264a4767ed8617b07e89285d9c24159/src/createEthApp.ts#L93

The copy operation depends upon an if block, so I take it that ncc doesn't bundle the gitignore file in the build dir. But I think this is confusing - ncc should optimistically look for all dynamical paths and add them to the bundle. Or at the very least it should give us a flag to enable this behavior back.

Here's the distributable for [email protected] (before upgrading ncc), and the distributable for [email protected] (after upgrading ncc).

How can we bring the old behavior back?

Update: I managed to get away by using the copyfiles package, which I run after the ncc part in my build script. But this is rather verbose and doesn't scale. It would still be good to have NCC bundle the dynamically imported files.

[styfle]

If you have multiple tsconfig.json files, then perhaps the walkParentDirs()from #770 is detecting the wrong config?

[louisgv]

For my project, I have moved my import to statically analyzable import, which allowed ncc to find and bundle the modules:

import { Router } from "express"

const routeModules = [
  import("auth"),
  import("user"),
  import("ping"),
  // 30+ more routes
]

export const setupApiRoutes = async () => {
  const router = Router()

  await Promise.all(
    routeModules.map((mod) =>
      mod.then((m) => router.use("/", m.default))
    )
  )

  return router
}

A quick write up: https://dev.to/louisgv/typescript-dynamic-module-import-2dln

[PaulRBerg]

If you have multiple tsconfig.json files, then perhaps the walkParentDirs()from #770 is detecting the wrong config?

I don't have multiple tsconfig.json files. Maybe @louisgv has?

I have moved my import to statically analyzable import

Thanks for posting an update with the solution you found :)

[louisgv]

I do have multiple tsconfig.json in my monorepo but the bundle only run under one leaf config (that extend root config)