Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically imputing time units for ordinal scales #6592

Open
kanitw opened this issue Jun 6, 2020 · 6 comments
Open

automatically imputing time units for ordinal scales #6592

kanitw opened this issue Jun 6, 2020 · 6 comments
Labels
Enhancement 🎉 P2 Important Issues that should be fixed soon RFC / Discussion 💬 For discussing proposed changes

Comments

@kanitw
Copy link
Member

kanitw commented Jun 6, 2020

(Forked from #6589)

For example, there are 7 days in a week, but without manual imputation we show this:

image

cc: @willium

@kanitw kanitw added Bug 🐛 RFC / Discussion 💬 For discussing proposed changes Feature Request 🙋‍♀️ P2 Important Issues that should be fixed soon P3 Should be fixed at some point and removed P3 Should be fixed at some point labels Jun 6, 2020
@kanitw
Copy link
Member Author

kanitw commented Jun 6, 2020

Though it's unclear (1) what should be the syntax to enable / disable automatic imputation and (2) which time units should be automatically imputed.

For (2), quarter, month, day obviously should be imputed. But what about "date", "hours", "seconds"?

@kanitw kanitw changed the title automatic imputing time units for ordinal scales automaticly imputing time units for ordinal scales Jun 6, 2020
@kanitw kanitw changed the title automaticly imputing time units for ordinal scales automatically imputing time units for ordinal scales Jun 6, 2020
@willium
Copy link
Member

willium commented Jun 6, 2020

(1) If we make tick counts better for the day time units (as in the second screenshot in the original issue), will it be necessary to impute?

for (2) I think those ought to be as well (+ minutes) so long as we don't allow for fractional dates, hours, or minutes, seconds.

@willium
Copy link
Member

willium commented Jun 6, 2020

For documentation's sake, I believe Vega's timeSequence expression will be useful for doing the imputation.

@willium
Copy link
Member

willium commented Jun 6, 2020

For (1) could we not use the existing nice property? for example

If not, I propose we add a boolean temporal scale property impute much like how continuous scales have a interpolate property.

@domoritz
Copy link
Member

domoritz commented Jun 7, 2020

Help me remember, but I think we removed imputation from time units with ordinal some time ago since we don’t really want imputation for any time unit (e.g. month date) with too many values. While I agree that imputation is often useful, I don’t think I want it to be the default.

@colleen-love
Copy link

Would it be possible to update the documentation to say that it's not possible to impute temporal series? Or log a warning in the console?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 🎉 P2 Important Issues that should be fixed soon RFC / Discussion 💬 For discussing proposed changes
Projects
None yet
Development

No branches or pull requests

4 participants