Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require IntelliJ IDEA to index node_modules #2417

Open
anssit opened this issue Sep 15, 2021 · 0 comments
Open

Do not require IntelliJ IDEA to index node_modules #2417

anssit opened this issue Sep 15, 2021 · 0 comments

Comments

@anssit
Copy link
Contributor

anssit commented Sep 15, 2021

Indexing node_modules is slow, and many developers would prefer to leave it unindexed. However, Vaadin Designer currently depends on indexed node_modules in its web component discover process.

Designer web components discovery should be changed so that it is based on the information in package.json. Designer should check the dependencies specified in package.json for web components instead of scanning the whole node_modules folder.

In addition to relaxing the indexing requirement, this change should result in a considerably faster web components scanning process, both in IntelliJ IDEA and Eclipse. Yet another benefit over directly scanning node_modules is that it will then become easier to further develop the implementation so that the components can be looked up from another source, like CDN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant