Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Arguments problem in computeAsymetry #80

Closed
thomasarsouze opened this issue Jan 24, 2024 · 1 comment · Fixed by #89
Closed

[Bug]: Arguments problem in computeAsymetry #80

thomasarsouze opened this issue Jan 24, 2024 · 1 comment · Fixed by #89
Assignees
Labels
bug Something isn't working minor

Comments

@thomasarsouze
Copy link
Contributor

What happened?

computeAsymetry function currently takes direction as an argument, but is never used. Also, this argument is not described in the document.

What is the expected behaviour ?

Minimal Complete Verifiable Example

No response

Propose a solution

We should remove direction argument to the function and from all the calls to this function in the code / tests / vignettes

Anything else we need to know?

No response

Environment

@thomasarsouze thomasarsouze added bug Something isn't working minor labels Jan 24, 2024
@thomasarsouze
Copy link
Contributor Author

@BaptisteDlp and @thomaspibanez : can you confirm that direction argument is not needed in this function ? Just need your confirmation before taking care of doing the code modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants