Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aggregation function alias pushdown #6189

Closed
wendigo opened this issue Dec 3, 2020 · 3 comments
Closed

Fix aggregation function alias pushdown #6189

wendigo opened this issue Dec 3, 2020 · 3 comments
Labels
good first issue Good for newcomers
Milestone
353

Comments

@wendigo
Copy link
Contributor

wendigo commented Dec 3, 2020 •
edited by findepi
Loading

Today if the given aggregation function is pushed down into the connector both name and alias (if declared for function) are pushed down to the applyAggregation(). Alias should be resolved to name instead.

relates to #6736
@wendigo wendigo added the good first issue Good for newcomers label Dec 3, 2020
@brandboat
Copy link
Member

Hello, I would like to take over this issue. Could you provide a SQL statement that reproduce this issue ? Many thanks. 😃

@wendigo
Copy link
Contributor Author

wendigo commented Dec 10, 2020 •
edited
Loading

@brandboat

I.e. when variance() or var_samp() (alias of variance()) aggregation functions (implemented in VarianceAggregation) are pushed down to the connector, AggregateFunction.functionName will contain either variance or var_samp but only canonical name should be used (variance as var_samp is an alias of variance)

@brandboat
Copy link
Member

Thanks for your comments ! I will try to fix it. 🙇

@brandboat brandboat mentioned this issue Jan 3, 2021
Closed
@findepi findepi mentioned this issue Jan 15, 2021
Open
18 tasks
This was referenced Jan 27, 2021
Merged
Closed
@findepi findepi added this to the 353 milestone Feb 26, 2021
@findepi findepi closed this as completed Feb 26, 2021
@findepi findepi mentioned this issue Feb 26, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Milestone
353
Development

Successfully merging a pull request may close this issue.

Fix aggregation function alias pushdown brandboat/trino
3 participants
@wendigo @findepi @brandboat