Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the Title input contradicts the HTML global title attribute #76

Open
fadisdh opened this issue Oct 4, 2019 · 5 comments
Open

the Title input contradicts the HTML global title attribute #76

fadisdh opened this issue Oct 4, 2019 · 5 comments

Comments

@fadisdh
Copy link

fadisdh commented Oct 4, 2019

Describe the bug
ngx-joyride is using the title input for the step title. This contradicts the HTML global title attribute which results in showing a tooltip over the content of the step which can be annoying for large areas.

To Reproduce
Steps to reproduce the behavior:

  1. Hover over an element that has a joyrideStep directive. (without the tour guide being active).
  2. The browser will show a tooltip for that element.

Expected behavior
Not show the default browser tooltip for the element that uses joyrideStep

Screenshots
If applicable, add screenshots to help explain your problem.

Details:

  • Browser: Any
@fadisdh fadisdh changed the title the Title input contradicts with the HTML global title attribute the Title input contradicts the HTML global title attribute Oct 4, 2019
@Dji75
Copy link

Dji75 commented Oct 4, 2019

Just write [title]="'your title'" instead of title="your title"

@bazter
Copy link

bazter commented Oct 4, 2019

The problem is in the input name itself, it's a bad decision to name a directive input with standard name like "title". What if I'd like to keep the default title attribute behavior? Author should consider an API change. Use prefixes, just like Angular devs recommend in the docs..

@Dji75
Copy link

Dji75 commented Oct 4, 2019

Totally agree with you, this is just a workaround ;)

@fadisdh
Copy link
Author

fadisdh commented Oct 4, 2019

Thanks @Dji75 for the solution, but as @bazter said its an API design issue.
Also, using [title]="'Some Title'" will not work with internationalization (i18n)

@Ashish117
Copy link

@tnicola this is an actual problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants