Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the selected item is not highlighted #34

Open
dfguns89 opened this issue Feb 13, 2019 · 5 comments
Open

the selected item is not highlighted #34

dfguns89 opened this issue Feb 13, 2019 · 5 comments
Labels
need reproduction This bug need to be reproduced in some way

Comments

@dfguns89
Copy link

dfguns89 commented Feb 13, 2019

Describe the bug

I am using version 2.0.0 of ngx-joyride in my angular application 5.2.11 and there are elements that are not highlighted. it works well in certain places of the html but in others it does not.

As shown in the attached file does not work:
bug.html.zip

@tnicola
Copy link
Owner

tnicola commented Feb 13, 2019

Hi @dfguns89 ,
Can you send me also the typescript file to better understand what is going on?

Thanks

@dfguns89
Copy link
Author

The library works well, only that in certain elements it is not highlighted and in others it does. When the error occurs, the popover is generated at the top of the page and not on the item that should. I sent two images with one error and the other correct. Would appreciate your help.

bugNgx.zip

@tnicola
Copy link
Owner

tnicola commented Feb 13, 2019

Thanks for the response and the materials.

  • Do you have any error on the browser console?
  • Is it really that element (Información) in the panelControl route?

@dfguns89
Copy link
Author

-No errors are displayed by console.
-I do not understand what you mean by the second question.
but I'm calling routes this way . this.joyrideService.startTour({ steps: ['firstStep@listaTurnos', 'secondStep@panelControl','thirdStep@verServicio','forthStep@verServicio','fifthStep@alertas','sixthStep@verHorario','seventhStep@editarSitio','eigthStep@editarSitio','ninethStep@editarSitio','tenthStep@editarSitio','eleventhStep@mensajesCorreo','twelfthStep@profesionales','thirteenthStep@listaClientes','fourteenth@calendario','fiftennthStep@reportesEmpresa','finalStep@listaTurnos'], themeColor:'#00FFFFFF' });

-another problem there is when the second step should be shown the last step is shown.

@tnicola
Copy link
Owner

tnicola commented Feb 14, 2019

It seems a problem with the routes. Are you using the @angular/router to navigate across pages?Are you sure all the routes are correct?

Could you try this code and sent back the results, please?

  this.joyrideService.startTour({
      steps: ['firstStep@listaTurnos', 'secondStep@panelControl','thirdStep@verServicio'],
      themeColor:'#00BABA'
     }).subscribe(
            step => {
                console.info('Location', window.location.href, "Path", window.location.pathname);
                console.info('Next:', step);
            },
            e => {
                console.info('Error', e);
            },
            () => {
                console.info('Tour finished');
            }
        );

@tnicola tnicola added the need reproduction This bug need to be reproduced in some way label Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need reproduction This bug need to be reproduced in some way
Projects
None yet
Development

No branches or pull requests

2 participants