This repository was archived by the owner on Jan 10, 2025. It is now read-only.
Improve image links #149
Merged
Improve image links #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make image links stand out and yet be different from regular links. Closes GH-140
mdcat used to send the entire URL to iterm2 as file name, but I seem to have misunderstood the inline images protocol of iterm2 here. The protocol seems toimply that the filename is really just the name of a file.
Do not use purple colour for images inside inline links, to clarify that the link always points to the link target and not to the image. Keep purple colour for the image link reference however.
If the terminal doesn't support inline images we try to render the link as inline link if the terminal supports it and the link isn't nested. Closes GH-141
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.