Skip to content
This repository was archived by the owner on Jan 10, 2025. It is now read-only.

Image Scaling with Kitty #124

Closed
ghost opened this issue Feb 29, 2020 · 3 comments
Closed

Image Scaling with Kitty #124

ghost opened this issue Feb 29, 2020 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Feb 29, 2020

This is mostly an inconsistency between how kitty normally behaves with images, and how it seems to work in mdcat.

if i mdcat a file that has an image too wide for the current kitty window, the image just doesn't load. however, if i kitty icat that same image, it shows up, scaled down to fit the terminal window appropriately.

is this intended mdcat behavior?

@swsnr
Copy link
Owner

swsnr commented Mar 4, 2020

I don't think so, but then I don't use kitty and didn't write this part of mdcat.

That said I guess it should scale down, and I think it used to when this feature was initially contributed to mdcat.

Perhaps I broke it when refactoring or perhaps by updating the image crate but I don't know why or how. In any case I don't have time to fix it; if you'd like it fixed please do open a pull request.

@swsnr swsnr added enhancement New feature or request help wanted Extra attention is needed labels Mar 10, 2020
@fspillner
Copy link
Contributor

@Fidgetcetera Thanks for reporting this. I've opened a PR aiming to fix your issue in general. You may have a look in my PR and test my fix. Additionally, the resizing may not work as expected and check my PR for the details.

@swsnr swsnr closed this as completed in 5d8c0ed May 24, 2020
@swsnr
Copy link
Owner

swsnr commented May 24, 2020

@fspillner @Fidgetcetera I released 0.17.1 which should fix this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants