Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManifestRegistry is broken #484

Open
piotmag769 opened this issue Mar 17, 2025 · 0 comments · May be fixed by #507
Open

ManifestRegistry is broken #484

piotmag769 opened this issue Mar 17, 2025 · 0 comments · May be fixed by #507
Assignees

Comments

@piotmag769
Copy link
Collaborator

Problem

path.starts_with(manifest_dir).then(|| config.clone())

This line is wrong, example:

.
|-- src
|-- Scarb.toml
`-- crates/
    `-- essa/
        |-- src/
        |   `-- lib.cairo
        `-- Scarb.toml

for essa/src/lib.cairo we may use ./Scarb.toml instead of essa/Scarb.toml

Steps

No response

Possible Solution(s)

No response

Notes

No response

Scarb Version


@mkaput mkaput moved this from Triage to Sranie in Cairo Language Services Mar 19, 2025
@mkaput mkaput moved this from Sranie to Backlog LS in Cairo Language Services Mar 19, 2025
@mkaput mkaput moved this from Backlog LS to Todo in Cairo Language Services Mar 19, 2025
@piotmag769 piotmag769 moved this from Todo to In Progress in Cairo Language Services Mar 21, 2025
@piotmag769 piotmag769 linked a pull request Mar 25, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant