Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid hover and goto on u96 type #466

Open
integraledelebesgue opened this issue Mar 12, 2025 · 2 comments
Open

Invalid hover and goto on u96 type #466

integraledelebesgue opened this issue Mar 12, 2025 · 2 comments

Comments

@integraledelebesgue
Copy link
Member

integraledelebesgue commented Mar 12, 2025

Hover for u96 type in corelib's circuit_test contains the BoundedInt, which u96 aliases, instead of the u96 itself.
"Go to definition" also points to the original type, not to the definition of u96.

Image

same happens for impl aliases:

// Pow implementation for any algebra.
impl AnyAlgebraPow<A, impl AlgImp: Algebra<A>> of Pow<A> { ... }

// Impl alias for Pow of i32.
impl Int32Pow = AnyAlgebraPow<i32, I32Algebra>;

// do goto definition on Int32Pow usage
@mkaput
Copy link
Member

mkaput commented Mar 13, 2025

I think the expected hover should show something akin to:

path:to::u96
pub type u96 = core::internal::bounded_int::BoundedInt<MINMAX>;

@mkaput mkaput moved this from Triage to Backlog LS in Cairo Language Services Mar 13, 2025
@mkaput
Copy link
Member

mkaput commented Mar 13, 2025

Goto definition, find references and rename also looks to be broken, cc #435

@mkaput mkaput marked this as a duplicate of #435 Mar 13, 2025
@mkaput mkaput marked this as a duplicate of #181 Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog LS
Development

No branches or pull requests

2 participants