Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition when restarting proc macro server with responses #443

Open
Draggu opened this issue Mar 7, 2025 · 0 comments
Open

Race condition when restarting proc macro server with responses #443

Draggu opened this issue Mar 7, 2025 · 0 comments
Assignees

Comments

@Draggu
Copy link
Contributor

Draggu commented Mar 7, 2025

When restarting proc macro server we call db.cancell_all() to make sure that no request will be ended during restart, but we are not handling case when there is a response in same time, this res will be pushed to old client queue so it wont be read but it still emits message to response channel used on main loop. We should send message to connection to stop handling requests before we restart and wait for connection to close.

@Draggu Draggu added this to the Proc macros support milestone Mar 7, 2025
@mkaput mkaput changed the title Proc macro server failure Race condition when restarting proc macro server with responses Mar 10, 2025
@mkaput mkaput moved this from Triage to Backlog LS in Cairo Language Services Mar 10, 2025
@mkaput mkaput moved this from Backlog LS to Todo in Cairo Language Services Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants