You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add a kind field to FoundUsage struct and plumb it into textDocument/documentHighlight response.
The value of the kind field should be inferred as a separate step while/just before building FoundUsage instance. This should be fairly easy to infer from the AST location itself:
If usage is a binding in let pat = ... statement, or function/closure parameter (or similar) → kind = Write.
If usage is in doc comment → kind = Text
Otherwise, → kind = Read.
Notes
No response
The text was updated successfully, but these errors were encountered:
Problem
We are not setting the
kind
of found reference intextDocument/documentHighlight
responses: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#documentHighlightKindProposed Solution
Add a
kind
field toFoundUsage
struct and plumb it intotextDocument/documentHighlight
response.The value of the
kind
field should be inferred as a separate step while/just before buildingFoundUsage
instance. This should be fairly easy to infer from the AST location itself:let pat = ...
statement, or function/closure parameter (or similar) →kind = Write
.kind = Text
kind = Read
.Notes
No response
The text was updated successfully, but these errors were encountered: