Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: HTTP Caching #293

Open
ericlathrop opened this issue Nov 2, 2024 · 1 comment
Open

Discussion: HTTP Caching #293

ericlathrop opened this issue Nov 2, 2024 · 1 comment

Comments

@ericlathrop
Copy link

Hey, I wanted to start a dialogue with y'all about HTTP caching.

I'm working on building an HTTP caching library on top of finch.

Goals

  1. follow all the rules set out in RFC 9111 pretty comprehensively
  2. well tested and documented
  3. pluggable cache storage, bundled with :ets storage
  4. API similar to Finch.request/3

Points for discussion

  1. I spent a little while poking around hex.pm for a caching library and didn't find one. If you know of anything, please send me a link.
  2. I was thinking of naming it FinchCache / finch_cache Is that okay? If not, suggestions?
  3. I'd guess you'd want to keep it a separate library so you don't increase your maintenance burden, but if you'd want to merge something like this, I'm open to it.
@sneako
Copy link
Owner

sneako commented Feb 20, 2025

Sorry for the late reply!

I'll address your points for discussion:

  1. Req offers a cache step but perhaps it is not as complete as you want? To me this feature really sounds something that belongs more at the Req level. Finch is really just trying to provide solid pools for Mint.
  2. I have no problem with you using the Finch name in your lib if you decide to go that route
  3. Yes, as I briefly touched on in 1, these kinds of features are out of scope for Finch and I wouldn't want to add it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants