Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Likely suffers from same issue as go-spew, unable to detect certain cycles. #11

Open
dmitshur opened this issue Sep 27, 2016 · 0 comments
Open

Likely suffers from same issue as go-spew, unable to detect certain cycles. #11

dmitshur opened this issue Sep 27, 2016 · 0 comments

Comments

@dmitshur
Copy link
Collaborator

Need to investigate this and fix this.

See davecgh/go-spew#53.

Originally discovered in kortschak/utter#5.
emidoots pushed a commit to hexops/autogold that referenced this issue Dec 31, 2020
switch from go-cmp to valast
d0446d7 
[Valast](https://github.com/hexops/valast) is a new Go package created
specifically for autogold. A brief overview of the ecosystem:

- go-cmp compares Go values using reflection, but cannot format Go
  values into Go-syntax strings for saving to a .golden file.
- go-spew is inactive, cannot format Go values to Go-syntax (but
  rather just Go-like) which is desirable here for inline snapshotting
  later.
- go-goon is based on go-spew and writes Go-syntax, but but not via a `go/ast`,
  and [produces less idiomatic/terse results](shurcooL-deprecated/go-goon#11))

In short, Autogold was created to solve the problem of automatic golden
file and inline snapshotting testing in Go (which go-cmp does not aim
to solve), and Valast was created to solve the deficiencies I ran into
with using go-goon.

Signed-off-by: Stephen Gutekanst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmitshur