thread: do not use fortify source

It causes problems with longjmp

    *** longjmp causes uninitialized stack frame ***: terminated
    Aborting on shard 0.
    Backtrace:

which was taken care of in the cmake build, but needs to be fixed in our
bazel build. reference: #2344

Closes #2522

Author: dotnwat

CMakeLists.txt

@@ -780,10 +780,6 @@ add_library (seastar
   src/websocket/server.cc
   )
 
-# We disable _FORTIFY_SOURCE because it generates false positives with longjmp() (src/core/thread.cc)
-set_source_files_properties(src/core/thread.cc
-  PROPERTIES COMPILE_FLAGS -U_FORTIFY_SOURCE)
-
 add_library (Seastar::seastar ALIAS seastar)
 
 add_dependencies (seastar

src/core/thread.cc

@@ -1,3 +1,8 @@
+// If _FORTIFY_SOURCE is defined then longjmp ends up using longjmp_chk
+// which asserts that you're jumping to the same stack. However, here we
+// are intentionally switching stacks when longjmp'ing, so undefine this
+// option to always use normal longjmp.
+#undef _FORTIFY_SOURCE
 /*
  * This file is open source software, licensed to you under the terms
  * of the Apache License, Version 2.0 (the "License").  See the NOTICE file