Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format overflow in staout #119

Open
brey opened this issue Dec 17, 2023 · 1 comment
Open

Format overflow in staout #119

brey opened this issue Dec 17, 2023 · 1 comment

Comments

@brey
Copy link
Contributor

brey commented Dec 17, 2023

https://github.com/schism-dev/schism/blob/c36e9498a39c0386a2048c2b45a61e6578b878f4/src/Hydro/schism_step.F90#L10278C13-L10278C72

When saving time in secs for long runs i.e. hindcasts, the time format is not appropriate. E.g. if you are saving every step (150 secs) and run for a year, after a few months the accumulated seconds number exceeds the format.

I suggest that the time reference is replaced with a timestamp in string in order to avoid such issues.

@josephzhang8
Copy link
Member

@brey I've changed the output format to e24.16, which should be good for 10s of years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants