Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

field 0 of struct quinn::StreamId is private #1079

Closed
awnion opened this issue Mar 18, 2025 · 7 comments
Closed

field 0 of struct quinn::StreamId is private #1079

awnion opened this issue Mar 18, 2025 · 7 comments

Comments

@awnion
Copy link

awnion commented Mar 18, 2025

Describe the bug

error[E0616]: field `0` of struct `quinn::StreamId` is private
   --> /usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/salvo-http3-0.4.0/src/http3_quinn.rs:484:14
    |
484 |             .0
    |              ^ private field

error[E0616]: field `0` of struct `quinn::StreamId` is private
   --> /usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/salvo-http3-0.4.0/src/http3_quinn.rs:626:14
    |
626 |             .0
    |              ^ private field

   Compiling moka v0.12.10
    Checking base64 v0.13.1
    Checking async-lock v3.4.0
    Checking tower v0.5.2
For more information about this error, try `rustc --explain E0616`.
error: could not compile `salvo-http3` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

To Reproduce
Steps to reproduce the behavior:

cargo check --all-features

Expected behavior
Compilation OK

Screenshots
Image

Desktop:

Additional context

@awnion
Copy link
Author

awnion commented Mar 18, 2025

this commit broke the code due to 0 field of StreamId became private

quinn-rs/quinn@43b74b6#diff-45fd3cfd722e7b87adcfadc0508468e208c6a307d65d94f76bc0e266bab99695L221

this PR: quinn-rs/quinn#2099

@elasticLove1
Copy link

Please, fix this issue, its critical for our project:(

@Futurizt
Copy link

Unfortunately we cannot fall back to the previous commit as there is another compilation error, so its really broken like completely :( we also can't vendor because there are many other libs that are based on you. Please please fix it as soon as you can ;(

@vitpankin
Copy link

Yeah, seems legit, looks like a regression.

@awnion
Copy link
Author

awnion commented Mar 18, 2025

Once salvo-rs/salvo-http3#1 is merged upstream, it should resolve this issue

@Deniskore
Copy link

I'm experiencing the same issue in our project. Creating temporary forks of multiple crates doesn't seem like an appealing solution to the issue. Is there any way I can assist in speeding up the release of the new version with the fixes @chrislearn ?

@chrislearn
Copy link
Member

Try to run cargo update and build again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants