Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut away Lyricwiki clutter on end #93

Open
omgold opened this issue Jun 7, 2019 · 0 comments
Open

Cut away Lyricwiki clutter on end #93

omgold opened this issue Jun 7, 2019 · 0 comments

Comments

@omgold
Copy link

omgold commented Jun 7, 2019

For quite a while lyrics from Lyricwiki append several lines of garbage like "External linksNominate as Song of the Day..."

It seems that the end detection in the html parsing is not good anymore. For me it works better, e.g. like this:

--- lib/intern/lyrics/lyricswiki.c.orig 2019-06-07 13:22:06.149875353 +0200
+++ lib/intern/lyrics/lyricswiki.c 2019-06-07 13:22:17.587382031 +0200
@@ -65,7 +65,7 @@

#define LYR_NODE "<div class='lyricbox"
#define LYR_BEGIN ">"
-#define LYR_ENDIN "<!--"
+#define LYR_ENDIN "<div class='lyricsbreak"
#define LYR_FOOTER "<div id="songfooter"
#define LYR_CREDITS "<table"
#define LYR_INSTRUMENTAL "/Category:Instrumental"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant