-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semi-Systematic Logo-Addition Evaluation #1616
Comments
I would like to specifically invite @hasecilu for some discussion, but I would be pleased by anyone leaving constructive comments here. I'm always very reluctant to add anything to the custom set. Usually Nerd Fonts aggregates icon sets and is not an icon set of its own right. The custom set is for giving icons a chance that have no chance upstream but are deemed to be nerd-ish enough. Whatever that means. Popularity of course helps, but then, if it's popular there is no need to use the fallback solution of NF-custom-icons ;-) See the contradiction? And then, in principle we could add all of these, but that might prompt more and more requests and the codepoints will be depleted quickly (in like 3 years or so?) If people see it is not likely to be added they might refrain from raising a glyph request 😬 From the above, I personally would probably add
For some, like Bun, I have no clue how people want to use it? In the title of a window? Not in a Powerline I assume. This is no source of joy for me 😬 |
Hi, sorry for not answering before, just got time to go through this. I agree with the fact that Nerd Fonts should be feeded with full sets rather than focusing on bringing individual glyphs. A lot of upstream projects have a specific topic/thematic that already fits with a lot of the requests here on NF but also some other projects that use icons (specially for decorating filetypes like web-devicons and many more). In #615 is mentioned the option to update current devicon font with the new one from still mantained
their last release about 3 months ago https://github.com/devicons/devicon/releases/tag/v2.16.0 (322 New/Updated Icons). They have a very active issue tracker and also there are a lot of contributions there. Doing a quick search on https://devicon.dev/ tell us that some of the requested icons are there:
They claim to have 473 icons, quite a lot (we only have 198) but: the last used devicon icon is From my perspective it seems that a lot of request are directly tied to people using terminal apps (most of time developers/sysadmins trying to make their environment pretty) so, a lot of DEV related icons could be expected to be requested. We can only make more accurate claims reading the feedback from users and cli app developers so we may need to wait for it. Also, maybe creating a pull request template to encourage users trying to contribute icons here to look for an upstream project could help a little. Extra: it seems the "name" of the glyph is not set correctly (as in lib files), can confirm? |
I believe the |
Ah thanks @rockorager, I corrected the table. |
Regarding the devicons, lets see how the codepoint situation is right now: $ jq -r 'keys[] as $k | "0x\(.[$k] | .code) \($k)"' glyphnames.json | sort -g | sed 's/^..//'
...
e7bb dev-redhat
e7bc dev-scriptcs
e7c4 dev-sqllite
e7c5 dev-vim
ea60 cod-add
ea61 cod-lightbulb
ea62 cod-repo
ea63 cod-repo_forked
... Setting up some codepoint preservation stuff like with Font Awesome... |
Yes, the (The lib Edit: |
Fixed this in 71e7ae0 (which is part of PR 1691). Thanks for mentioning! |
I'm developing projects with Bun, and I'd like to have a Nerd Font icon for it in my shell prompt. The one on https://devicon.dev/ looks great. Currently, since Nerd Font doesn't have it, starship uses this emoji Which doesn't seem to be fit with my custom airline theme, so I don't have a good icon for Bun project. Thanks in advance if you can add it into Nerd Font! |
The filled bun in in #1691 which will most likely come in the next ... days 😬 At the moment I'm tackling a problem with the CommitMono font, which has a bug upstream of upstream, trying to fix it there (i.e. |
So lets tackle the last two after done the progress things. |
There are several logo requests but it is extremely hard to decide which ones should be included and which should be rejected.
This Issue shall serve as a platform to evaluate them one by one.
What do we have in #1095?
Current custom block space
E700
-E6B6
= 74 iconsEdit: Change round half blocks #glyphs from 4 to 2
Edit: Mark icon additons solved by devicon update
The text was updated successfully, but these errors were encountered: