docs: Add entry for backslash_quotes liberal parsing #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
May 16, 2023
|
|
||
| With +liberal_parsing+ and its +backslash_quote+ sub-option: | ||
| ary = CSV.parse_line(str, liberal_parsing: { backslash_quotes: true }) | ||
| ary # => ["Show", "Harold \"Handcuff\" Houdini", "Tampa Theater"] |
There was a problem hiding this comment.
I think that the result is incorrect.
Could you check this again?
There was a problem hiding this comment.
@kou Thanks for catching that. I thought I had copied and pasted, but apparently not. backslash_quotes: true should be backslash_quote: true. I'll resubmit.
There was a problem hiding this comment.
Here's a console log:
~/code/csv/doc/csv/options/parsing git:(doc/add-liberal-parsing) docker run -it 1e6b2a26f38d bash
root@d277469b2d78:/# irb
irb(main):001:0> require 'csv'
=> true
irb(main):002:0> RUBY_VERSION
=> "3.2.0"
irb(main):003:0> str = 'Show,"Harry \"Handcuff\" Houdini, the one and only","Tampa Theater"'
=> "Show,\"Harry \\\"Handcuff\\\" Houdini, the one and only\",\"Tampa Theater\""
irb(main):004:0> ary = CSV.parse_line(str, liberal_parsing: true)
=> ["Show", "\"Harry \\\"Handcuff\\\" Houdini", " the one and only\"", "Tampa Theater"]
irb(main):005:0> puts ary[1]
"Harry \"Handcuff\" Houdini
=> nil
irb(main):006:0>
irb(main):007:0> ary = CSV.parse_line(str, liberal_parsing: { backslash_quote: true })
=> ["Show", "Harry \"Handcuff\" Houdini, the one and only", "Tampa Theater"]
irb(main):008:0> puts ary[1]
Harry "Handcuff" Houdini, the one and only
=> nil
There was a problem hiding this comment.
Sorry for the delay. I resubmitted just now.
markaschneider
force-pushed
the
doc/add-liberal-parsing
branch
from
f5e3a8b to
43feb3a
Compare
markaschneider
force-pushed
the
doc/add-liberal-parsing
branch
from
43feb3a to
b6b4627
Compare
|
Thanks! |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.