Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong resolution for waveshare_epd.epd7in3g, 168x400 but should be 800x480 #99

Closed
reinharty opened this issue Jun 23, 2024 · 3 comments · Fixed by #100
Closed

Wrong resolution for waveshare_epd.epd7in3g, 168x400 but should be 800x480 #99

reinharty opened this issue Jun 23, 2024 · 3 comments · Fixed by #100

Comments

@reinharty
Copy link
Contributor

reinharty commented Jun 23, 2024

Hello @robweber ,
thank you for this library.
I believe I might have found a bug in the implementation of the epd7in3g. Its a B/W,Red,Yellow screen.
When running the basic and init examples, it only draws to a small area instead of fullscreen:
PXL_20240622_133503155 jpg_compressed

Using the official Waveshare_epd example for the same screen, it draws to the whole screen:
PXL_20240622_140540571 jpg_compressed
(Ironically I only managed to get this to work after installing your module.)

Printing width and height results in 168 and 400 but should be 800x480.
Sadly I have been unable to identify where these values are loaded from.

@robweber
Copy link
Owner

Thanks for all of the information on this. I was able to locate the issue pretty quickly. Looks like the wrong Waveshare lib is being loaded for this display. For any of the displays that aren't checked as "confirmed working" this is pretty common to find a small thing. We did the best we could trying to translate all the individual driver falls.

I should be able to fix this up quick and get it in the repo. If you wouldn't mind confirming the fix after it's done I can mark this display as tested.

@reinharty
Copy link
Contributor Author

Thank you for your quick reply. Due to the comment I assumed it was the correct driver, hence, I did not test that change.
I will gladly test and confirm it as soon as possible.

@reinharty
Copy link
Contributor Author

Hi @robweber , I opened a PR with the fix and apended a picture as proof.

@robweber robweber linked a pull request Jun 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants